Messages in this thread | | | From | Igor Russkikh <> | Subject | Re: [EXT] [PATCH net-next] net: aquantia: Fix build error wihtout CONFIG_PTP_1588_CLOCK | Date | Fri, 25 Oct 2019 15:06:25 +0000 |
| |
> If PTP_1588_CLOCK is n, building fails: > > drivers/net/ethernet/aquantia/atlantic/aq_ptp.c: In function aq_ptp_adjfine: > drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:279:11: > error: implicit declaration of function scaled_ppm_to_ppb [-Werror=implicit-function-declaration] > scaled_ppm_to_ppb(scaled_ppm));
Hi Yue,
Thanks for noticing this. It seems I've added scaled_ppm_to_ppb usage but did not checked PTP_1588_CLOCK=n case after that.
> > Just cp scaled_ppm_to_ppb() from ptp_clock.c to fix this.
I'm honestly not sure if duplicating the code is a good way here. I'll think on how to exclude at_ptp at all on such a config.
Regards, Igor
| |