Messages in this thread | | | Date | Fri, 25 Oct 2019 12:42:30 +0200 | From | Michal Suchánek <> | Subject | Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code |
| |
On Thu, Oct 24, 2019 at 07:39:08PM -0700, Christoph Hellwig wrote: > On Thu, Oct 24, 2019 at 10:50:14AM +0200, Michal Suchánek wrote: > > Then I will get complaints I do unrelated changes and it's hard to > > review. The code gets removed later anyway. > > If you refactor you you pretty much have a card blanche for the > refactored code and the direct surroundings.
This is different from what other reviewers say:
https://lore.kernel.org/lkml/1517245320.2687.14.camel@wdc.com/
Either way, this code is removed in a later patch so this discussion is moot. It makes sense to have a bisection point here in case something goes wrong but it is pointless to argue about the code structure inherited from the previous revision.
Thanks
Michal
| |