Messages in this thread | | | Date | Wed, 23 Oct 2019 11:07:08 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v4 15/16] module: Move where we mark modules RO,X |
| |
On Tue, Oct 22, 2019 at 04:40:23PM -0400, Steven Rostedt wrote: > On Tue, 22 Oct 2019 22:24:01 +0200 > Peter Zijlstra <peterz@infradead.org> wrote:
> > I'm not particularly proud of the "__function__" hack, but it works :/ I > > If anything, that should be defined as a macro: > > #define TRACE_EVENT_FIELD_SPECIAL "__trace_event_special__" > > And use that to test?
Possibly, also, we should probably start with a character that C doesn't allow in typenames, like '$'.
That way we can have a much shorter string and still be certain it will never conflict; "$func" comes to mind.
> > couldn't come up with anything else for [uk]probes which seem to have > > dynamic fields and if we're having it then syscall_enter can also make > > use of it, the syscall_metadata crud was going to be ugly otherwise. > > > > (also, win on LOC) > > I'm more worried about text/data bloat. But if anything, we may be able > to deal with that later.
We use almost the exact same data the function would've used, except we don't have the actual function. I just don't see how it can be more.
| |