lkml.org 
[lkml]   [2019]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 15/16] module: Move where we mark modules RO,X
    On Tue, Oct 22, 2019 at 01:31:16PM +0200, Heiko Carstens wrote:
    > On Mon, Oct 21, 2019 at 06:11:35PM +0200, Peter Zijlstra wrote:
    > > On Mon, Oct 21, 2019 at 05:34:25PM +0200, Peter Zijlstra wrote:
    > > > On Mon, Oct 21, 2019 at 04:14:02PM +0200, Peter Zijlstra wrote:
    > >
    > > > So On IRC Josh suggested we use text_poke() for RELA. Since KLP is only
    > > > available on Power and x86, and Power does not have STRICT_MODULE_RWX,
    > > > the below should be sufficient.
    > > >
    > > > Completely untested...
    > >
    > > And because s390 also has: HAVE_LIVEPATCH and STRICT_MODULE_RWX the even
    > > less tested s390 bits included below.
    > >
    > > Heiko, apologies if I completely wrecked it.
    > >
    > > The purpose is to remove module_disable_ro()/module_enable_ro() from
    > > livepatch/core.c such that:
    > >
    > > - nothing relies on where in the module loading path module text goes RX.
    > > - nothing ever has writable text
    >
    > Given that Steven reported a crash, I assume I can wait until you
    > repost a new version of the series, which also includes s390 bits?

    His crash is somewhat orthogonal, but yes, I will repost once sorted.

    \
     
     \ /
      Last update: 2019-10-22 14:32    [W:4.623 / U:1.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site