Messages in this thread Patch in this message | | | From | Viresh Kumar <> | Subject | [PATCH] cpufreq: Clarify the comment in cpufreq_set_policy() | Date | Tue, 22 Oct 2019 15:47:57 +0530 |
| |
One of the responsibility of the ->verify() callback is to make sure that the policy's min frequency is <= max frequency as this isn't guaranteed by the QoS framework which gave us those values.
Update the comment in cpufreq_set_policy() to clarify that.
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/cpufreq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 2e698b5f0f80..b4b5f11c2f1e 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2384,7 +2384,10 @@ int cpufreq_set_policy(struct cpufreq_policy *policy, new_policy->min = freq_qos_read_value(&policy->constraints, FREQ_QOS_MIN); new_policy->max = freq_qos_read_value(&policy->constraints, FREQ_QOS_MAX); - /* verify the cpu speed can be set within this limit */ + /* + * Verify that the cpu speed can be set within this limit and make sure + * min <= max. + */ ret = cpufreq_driver->verify(new_policy); if (ret) return ret; -- 2.21.0.rc0.269.g1a574e7a288b
| |