lkml.org 
[lkml]   [2019]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 2/2] drm/bridge: Add NWL MIPI DSI host controller support
Hi,
On Mon, Oct 21, 2019 at 07:11:12PM +0800, kbuild test robot wrote:
> Hi "Guido,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [cannot apply to v5.4-rc4 next-20191018]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see
> https://stackoverflow.com/a/37406982]

The base for this series is next-20191018 where drm_panel_bridge_add()
list it's second argument (89958b7cd9555a5d82556cc9a1f4c62fffda6f96).

Cheers,
-- Guido

>
> url: https://github.com/0day-ci/linux/commits/Guido-G-nther/dt-bindings-display-bridge-Add-binding-for-NWL-mipi-dsi-host-controller/20191021-180825
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7d194c2100ad2a6dded545887d02754948ca5241
> config: mips-allmodconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/gpu/drm/bridge/nwl-dsi.c: In function 'nwl_dsi_host_attach':
> >> drivers/gpu/drm/bridge/nwl-dsi.c:384:12: error: too few arguments to function 'drm_panel_bridge_add'
> bridge = drm_panel_bridge_add(panel);
> ^~~~~~~~~~~~~~~~~~~~
> In file included from include/drm/drm_crtc.h:44:0,
> from include/drm/drm_atomic_helper.h:31,
> from drivers/gpu/drm/bridge/nwl-dsi.c:24:
> include/drm/drm_bridge.h:432:20: note: declared here
> struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
> ^~~~~~~~~~~~~~~~~~~~
>
> vim +/drm_panel_bridge_add +384 drivers/gpu/drm/bridge/nwl-dsi.c
>
> 358
> 359 static int nwl_dsi_host_attach(struct mipi_dsi_host *dsi_host,
> 360 struct mipi_dsi_device *device)
> 361 {
> 362 struct nwl_dsi *dsi = container_of(dsi_host, struct nwl_dsi, dsi_host);
> 363 struct device *dev = dsi->dev;
> 364 struct drm_bridge *bridge;
> 365 struct drm_panel *panel;
> 366 int ret;
> 367
> 368 DRM_DEV_INFO(dev, "lanes=%u, format=0x%x flags=0x%lx\n", device->lanes,
> 369 device->format, device->mode_flags);
> 370
> 371 if (device->lanes < 1 || device->lanes > 4)
> 372 return -EINVAL;
> 373
> 374 dsi->lanes = device->lanes;
> 375 dsi->format = device->format;
> 376 dsi->dsi_mode_flags = device->mode_flags;
> 377
> 378 ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
> 379 &bridge);
> 380 if (ret)
> 381 return ret;
> 382
> 383 if (panel) {
> > 384 bridge = drm_panel_bridge_add(panel);
> 385 if (IS_ERR(bridge))
> 386 return PTR_ERR(bridge);
> 387 }
> 388
> 389 dsi->panel_bridge = bridge;
> 390 drm_bridge_add(&dsi->bridge);
> 391
> 392 return 0;
> 393 }
> 394
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation


> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

\
 
 \ /
  Last update: 2019-10-22 10:46    [W:0.087 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site