Messages in this thread | | | From | Karol Herbst <> | Date | Mon, 21 Oct 2019 14:00:46 +0200 | Subject | Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges |
| |
On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg <mika.westerberg@intel.com> wrote: > > Hi Karol, > > Sorry for commenting late, I just came back from vacation. > > On Wed, Oct 16, 2019 at 04:44:49PM +0200, Karol Herbst wrote: > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > > states. > > > > v2: convert to pci_dev quirk > > put a proper technical explanation of the issue as a in-code comment > > v3: disable it only for certain combinations of intel and nvidia hardware > > > > Signed-off-by: Karol Herbst <kherbst@redhat.com> > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Lyude Paul <lyude@redhat.com> > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > > Cc: Mika Westerberg <mika.westerberg@intel.com> > > Cc: linux-pci@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: nouveau@lists.freedesktop.org > > --- > > drivers/pci/pci.c | 11 ++++++++++ > > drivers/pci/quirks.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ > > I may be missing something but why you can't do this in the nouveau > driver itself?
What do you mean precisely? Move the quirk into nouveau, but keep the changes to pci core?
| |