Messages in this thread | | | Subject | Re: [PATCH] KVM: remove redundant code in kvm_arch_vm_ioctl | From | Paolo Bonzini <> | Date | Mon, 21 Oct 2019 10:56:21 +0200 |
| |
On 21/10/19 10:16, Thomas Gleixner wrote: > Can you please get rid of that odd jump label completely? > > if (irqchip_kernel(kvm)) > r = kvm_vm_ioctl_set_irqchip(kvm, chip);
Keeping the label has the advantage of making the get and set cases a bit more similar (the get case has to do a copy_to_user after kvm_vm_ioctl_get_irqchip returns). Unfortunately struct kvm_irqchip is quite big (520 bytes) so we don't allocate it on the stack.
So I queued Miaohe's patch.
Paolo
| |