lkml.org 
[lkml]   [2019]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 02/16] x86/mce: WARN once if IA32_FEATURE_CONTROL MSR is left unlocked
    Date
    WARN if the IA32_FEATURE_CONTROL MSR is somehow left unlocked now that
    CPU initialization unconditionally locks the MSR.

    Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
    Cc: Wanpeng Li <wanpengli@tencent.com>
    Cc: Jim Mattson <jmattson@google.com>
    Cc: kvm@vger.kernel.org
    Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    ---
    arch/x86/kernel/cpu/mce/intel.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c
    index 88cd9598fa57..1008f14b803b 100644
    --- a/arch/x86/kernel/cpu/mce/intel.c
    +++ b/arch/x86/kernel/cpu/mce/intel.c
    @@ -117,11 +117,10 @@ static bool lmce_supported(void)
    * generate a #GP fault.
    */
    rdmsrl(MSR_IA32_FEATURE_CONTROL, tmp);
    - if ((tmp & (FEATURE_CONTROL_LOCKED | FEATURE_CONTROL_LMCE)) ==
    - (FEATURE_CONTROL_LOCKED | FEATURE_CONTROL_LMCE))
    - return true;
    + if (WARN_ON_ONCE(!(tmp & FEATURE_CONTROL_LOCKED)))
    + return false;

    - return false;
    + return tmp & FEATURE_CONTROL_LMCE;
    }

    bool mce_intel_cmci_poll(void)
    --
    2.22.0
    \
     
     \ /
      Last update: 2019-10-22 01:57    [W:2.331 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site