Messages in this thread | | | Date | Mon, 21 Oct 2019 23:21:22 +0100 | From | Russell King - ARM Linux admin <> | Subject | Re: [PATCH v3 1/5] net: ag71xx: port to phylink |
| |
On Mon, Oct 21, 2019 at 07:38:07AM +0200, Oleksij Rempel wrote: > +static void ag71xx_mac_validate(struct phylink_config *config, > + unsigned long *supported, > + struct phylink_link_state *state) > { > - struct ag71xx *ag = netdev_priv(ndev); > + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; > + > + if (state->interface != PHY_INTERFACE_MODE_NA && > + state->interface != PHY_INTERFACE_MODE_GMII && > + state->interface != PHY_INTERFACE_MODE_MII) { > + bitmap_zero(supported, __ETHTOOL_LINK_MODE_MASK_NBITS); > + return; > + } > + > + phylink_set(mask, MII); > + > + /* flow control is not supported */ > + > + phylink_set(mask, 10baseT_Half); > + phylink_set(mask, 10baseT_Full); > + phylink_set(mask, 100baseT_Half); > + phylink_set(mask, 100baseT_Full); > > - ag71xx_link_adjust(ag, true); > + if (state->interface == PHY_INTERFACE_MODE_NA && > + state->interface == PHY_INTERFACE_MODE_GMII) {
This is always false.
Apart from that, from just reading the patch I have no further concerns.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
| |