lkml.org 
[lkml]   [2019]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drm/nouveau: Fix memory leak in nouveau_bo_alloc
    Date
    In the implementation of nouveau_bo_alloc() if it fails to determine the
    target page size via pi, then the allocated memory for nvbo should be
    released.

    Fixes: 019cbd4a4feb ("drm/nouveau: Initialize GEM object before TTM object")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    ---
    drivers/gpu/drm/nouveau/nouveau_bo.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
    index f8015e0318d7..18857cf44068 100644
    --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
    @@ -276,8 +276,10 @@ nouveau_bo_alloc(struct nouveau_cli *cli, u64 *size, int *align, u32 flags,
    break;
    }

    - if (WARN_ON(pi < 0))
    + if (WARN_ON(pi < 0)) {
    + kfree(nvbo);
    return ERR_PTR(-EINVAL);
    + }

    /* Disable compression if suitable settings couldn't be found. */
    if (nvbo->comp && !vmm->page[pi].comp) {
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-10-21 23:15    [W:5.154 / U:0.992 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site