Messages in this thread | | | Date | Sun, 20 Oct 2019 15:04:40 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH] power: reset: fix __le32 cast in reset code |
| |
Hi,
On Tue, Oct 15, 2019 at 04:54:14PM +0100, Ben Dooks (Codethink) wrote: > The writel() takes standard integers, not __le32 so > fix the following sparse warnings by removing the > cpu_to_le32() calls. > > drivers/power/reset/at91-reset.c:134:9: warning: cast from restricted __le32 > drivers/power/reset/at91-reset.c:143:9: warning: cast from restricted __le32 > > This has made no code changes, the md5sums pre and post applying > this patch are the same. The at91 should be natively little endian > anyway. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > ---
Thanks, queued.
-- Sebastian
> Cc: Sebastian Reichel <sre@kernel.org> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Ludovic Desroches <ludovic.desroches@microchip.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/power/reset/at91-reset.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c > index 44ca983a49a1..d94e3267c3b6 100644 > --- a/drivers/power/reset/at91-reset.c > +++ b/drivers/power/reset/at91-reset.c > @@ -131,7 +131,7 @@ static int at91sam9g45_restart(struct notifier_block *this, unsigned long mode, > static int sama5d3_restart(struct notifier_block *this, unsigned long mode, > void *cmd) > { > - writel(cpu_to_le32(AT91_RSTC_KEY | AT91_RSTC_PERRST | AT91_RSTC_PROCRST), > + writel(AT91_RSTC_KEY | AT91_RSTC_PERRST | AT91_RSTC_PROCRST, > at91_rstc_base); > > return NOTIFY_DONE; > @@ -140,9 +140,7 @@ static int sama5d3_restart(struct notifier_block *this, unsigned long mode, > static int samx7_restart(struct notifier_block *this, unsigned long mode, > void *cmd) > { > - writel(cpu_to_le32(AT91_RSTC_KEY | AT91_RSTC_PROCRST), > - at91_rstc_base); > - > + writel(AT91_RSTC_KEY | AT91_RSTC_PROCRST, at91_rstc_base); > return NOTIFY_DONE; > } > > -- > 2.23.0 > [unhandled content-type:application/pgp-signature] | |