lkml.org 
[lkml]   [2019]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net] net: stmmac: Avoid deadlock on suspend/resume
From
From: Thierry Reding <thierry.reding@gmail.com>
Date: Wed, 2 Oct 2019 16:49:46 +0200

> From: Thierry Reding <treding@nvidia.com>
>
> The stmmac driver will try to acquire its private mutex during suspend
> via phylink_resolve() -> stmmac_mac_link_down() -> stmmac_eee_init().
> However, the phylink configuration is updated with the private mutex
> held already, which causes a deadlock during suspend.
>
> Fix this by moving the phylink configuration updates out of the region
> of code protected by the private mutex.
>
> Fixes: 19e13cb27b99 ("net: stmmac: Hold rtnl lock in suspend/resume callbacks")
> Suggested-by: Bitan Biswas <bbiswas@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Applied.

\
 
 \ /
  Last update: 2019-10-03 02:23    [W:0.021 / U:29.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site