Messages in this thread | | | Date | Wed, 2 Oct 2019 21:43:26 +0100 | From | Matthias Maennich <> | Subject | Re: [PATCH 0/7] module: various bug-fixes and clean-ups for module namespace |
| |
On Wed, Oct 02, 2019 at 08:57:02PM +0200, Jessica Yu wrote: >+++ Matthias Maennich [27/09/19 14:41 +0100]: >>On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote: >>> >>>I was hit by some problems caused by the module namespace feature >>>that was merged recently. At least, the breakage of >>>external module builds is a fatal one. I just took a look at the code >>>closer, and I noticed some more issues and improvements. >>> >>>I hope these patches are mostly OK. >>>The 4th patch might have room for argument since it is a trade-off >>>of "cleaner implermentation" vs "code size". >>> >>Thanks Masahiro for taking the time to improve the implementation of the >>symbol namespaces. These are all good points that you addressed! > >Agreed, thanks Masahiro for fixing up all the rough edges! Your series >of fixes look good to me, I will queue this up on modules-next this >week with the exception of patch 4 - Matthias, you are planning to >submit a patch that would supercede patch 04/07, right?
I will most likely create a patch on top of 04/07 and will submit everything as a separate series.
Cheers, Matthias
| |