lkml.org 
[lkml]   [2019]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH bpf 2/2] selftests/bpf: test_progs: don't leak server_fd in test_sockopt_inherit
On Wed, Oct 2, 2019 at 1:56 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On Tue, Oct 01, 2019 at 08:42:30PM -0700, Brian Vazquez wrote:
> > Thanks for reviewing the patches Andrii!
> >
> > Although Daniel fixed them and applied them correctly.
>
> After last kernel/maintainer summit at LPC, I reworked all my patchwork scripts [0]
> which I use for bpf trees in order to further reduce manual work and add more sanity
> checks at the same time. Therefore, the broken Fixes: tag was a good test-case. ;-)

Do you scripts also capitalize first word after libbpf: prefix? Is
that intentional? Is that a recommended subject casing:

"libbpf: Do awesome stuff" vs "libbpf: do awesome stuff"?

>
> Thanks,
> Daniel
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/
>
> > On Tue, Oct 1, 2019 at 8:20 PM Andrii Nakryiko
> > <andrii.nakryiko@gmail.com> wrote:
> > >
> > > On Tue, Oct 1, 2019 at 10:40 AM Brian Vazquez <brianvv@google.com> wrote:
> > > >
> > >
> > > I don't think there is a need to add "test_progs:" to subject, "
> > > test_sockopt_inherit" is specific enough ;)
> > >
> > > > server_fd needs to be close if pthread can't be created.
> > >
> > > typo: closed
> > >
> > > > Fixes: e3e02e1d9c24 ("selftests/bpf: test_progs: convert test_sockopt_inherit")
> > > > Cc: Stanislav Fomichev <sdf@google.com>
> > > > Signed-off-by: Brian Vazquez <brianvv@google.com>
> > > > ---
> > >
> > > Acked-by: Andrii Nakryiko <andriin@fb.com>
> > >
> > > > tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)

\
 
 \ /
  Last update: 2019-10-02 22:30    [W:0.048 / U:2.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site