[lkml]   [2019]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH] leds: core: Fix LED_COLOR_MAX_ID
On Wed 2019-10-02 11:34:00, Dan Murphy wrote:
> The LED_COLOR_MAX_ID is incorrect. THe MAX_ID should
> be the last COLOR_ID in the list. If an array was allocate
> with MAX_ID the allocation would be correct but the meaning
> is wrong.
> So for array allocation the code should use LED_NUM_COLOR_IDS
> which will allocate MAX_ID + 1. Whent the code needs to validate
> that the color ID is not out of bounds then the code should use

Renaming original define might have been okay. Having two defines is
not. I'd say we can keep it as is...


(cesky, pictures)
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-10-02 20:36    [W:0.030 / U:34.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site