Messages in this thread | | | Date | Wed, 02 Oct 2019 11:08:41 -0400 (EDT) | Subject | Re: [PATCH net] mlx5: avoid 64-bit division in dr_icm_pool_mr_create() | From | David Miller <> |
| |
From: Alex Vesker <valex@mellanox.com> Date: Wed, 2 Oct 2019 14:58:44 +0000
> On 10/2/2019 3:12 PM, Michal Kubecek wrote: >> Recently added code introduces 64-bit division in dr_icm_pool_mr_create() >> so that build on 32-bit architectures fails with >> >> ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! >> >> As the divisor is always a power of 2, we can use bitwise operation >> instead. >> >> Fixes: 29cf8febd185 ("net/mlx5: DR, ICM pool memory allocator") >> Reported-by: Borislav Petkov <bp@alien8.de> >> Signed-off-by: Michal Kubecek <mkubecek@suse.cz> ... > Align diff is power of 2, looks good to me. > Thanks for fixing it Michal.
I'll just apply this directly, thanks everyone.
| |