lkml.org 
[lkml]   [2019]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pwm: sun4i: redundant assignment to variable pval
From
Date
On 02/10/2019 14:25, Dan Carpenter wrote:
> On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Variable pval is being assigned a value that is never read. The
>> assignment is redundant and hence can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/pwm/pwm-sun4i.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
>> index 6f5840a1a82d..53970d4ba695 100644
>> --- a/drivers/pwm/pwm-sun4i.c
>> +++ b/drivers/pwm/pwm-sun4i.c
>> @@ -156,7 +156,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm,
>> if (sun4i_pwm->data->has_prescaler_bypass) {
>> /* First, test without any prescaler when available */
>> prescaler = PWM_PRESCAL_MASK;
>> - pval = 1;
>> /*
>> * When not using any prescaler, the clock period in nanoseconds
>> * is not an integer so round it half up instead of
>
> Are you sure? It looks used to me.

It's only read in a do_div() and before that it is being assigned:

pval = prescaler_table[prescaler];
div = clk_rate;
do_div(div, pval);

so the assigned value of pval = 1 is never read

Colin
>
> regards,
> dan carpenter
>

\
 
 \ /
  Last update: 2019-10-02 15:29    [W:0.048 / U:4.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site