Messages in this thread | | | From | Masahiro Yamada <> | Date | Wed, 2 Oct 2019 22:01:51 +0900 | Subject | Re: [PATCH v2] ARM: add __always_inline to functions called from __get_user_check() |
| |
Hi Nick,
On Wed, Oct 2, 2019 at 2:04 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Since that commit, all architectures can enable CONFIG_OPTIMIZE_INLINING. > > So, __always_inline is now the only guaranteed way of forcible inlining. > > No, the C preprocessor is the only guaranteed way of inlining.
I do not think this is fatal if I understood this correctly: https://lore.kernel.org/patchwork/patch/1122097/#1331784
For GCC, we at least get a warning if a function with __always_inline is not inlined. I am fine with adding -Werror=attributes to the top Makefile (unless we have unpleasant side-effects).
You filed the bug for Clang, and hopefully it will be OK in the future releases?
-- Best Regards Masahiro Yamada
| |