lkml.org 
[lkml]   [2019]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 5/9] rcu: Remove unused variable rcu_perf_writer_state
    Date
    From: Ethan Hansen <1ethanhansen@gmail.com>

    The variable rcu_perf_writer_state is declared and initialized,
    but is never actually referenced. Remove it to clean code.

    Signed-off-by: Ethan Hansen <1ethanhansen@gmail.com>
    [ ethansen: Also removed unused macros assigned to that variable. ]
    Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
    ---
    kernel/rcu/rcuperf.c | 16 ----------------
    1 file changed, 16 deletions(-)

    diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
    index 5a879d0..5f884d5 100644
    --- a/kernel/rcu/rcuperf.c
    +++ b/kernel/rcu/rcuperf.c
    @@ -109,15 +109,6 @@ static unsigned long b_rcu_perf_writer_started;
    static unsigned long b_rcu_perf_writer_finished;
    static DEFINE_PER_CPU(atomic_t, n_async_inflight);

    -static int rcu_perf_writer_state;
    -#define RTWS_INIT 0
    -#define RTWS_ASYNC 1
    -#define RTWS_BARRIER 2
    -#define RTWS_EXP_SYNC 3
    -#define RTWS_SYNC 4
    -#define RTWS_IDLE 5
    -#define RTWS_STOPPING 6
    -
    #define MAX_MEAS 10000
    #define MIN_MEAS 100

    @@ -404,25 +395,20 @@ rcu_perf_writer(void *arg)
    if (!rhp)
    rhp = kmalloc(sizeof(*rhp), GFP_KERNEL);
    if (rhp && atomic_read(this_cpu_ptr(&n_async_inflight)) < gp_async_max) {
    - rcu_perf_writer_state = RTWS_ASYNC;
    atomic_inc(this_cpu_ptr(&n_async_inflight));
    cur_ops->async(rhp, rcu_perf_async_cb);
    rhp = NULL;
    } else if (!kthread_should_stop()) {
    - rcu_perf_writer_state = RTWS_BARRIER;
    cur_ops->gp_barrier();
    goto retry;
    } else {
    kfree(rhp); /* Because we are stopping. */
    }
    } else if (gp_exp) {
    - rcu_perf_writer_state = RTWS_EXP_SYNC;
    cur_ops->exp_sync();
    } else {
    - rcu_perf_writer_state = RTWS_SYNC;
    cur_ops->sync();
    }
    - rcu_perf_writer_state = RTWS_IDLE;
    t = ktime_get_mono_fast_ns();
    *wdp = t - *wdp;
    i_max = i;
    @@ -463,10 +449,8 @@ rcu_perf_writer(void *arg)
    rcu_perf_wait_shutdown();
    } while (!torture_must_stop());
    if (gp_async) {
    - rcu_perf_writer_state = RTWS_BARRIER;
    cur_ops->gp_barrier();
    }
    - rcu_perf_writer_state = RTWS_STOPPING;
    writer_n_durations[me] = i_max;
    torture_kthread_stopping("rcu_perf_writer");
    return 0;
    --
    2.9.5
    \
     
     \ /
      Last update: 2019-10-03 03:48    [W:2.579 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site