[lkml]   [2019]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mmc: sh_mmcif: Use platform_get_irq_optional() for optional interrupt
On Tue, Oct 01, 2019 at 08:08:34PM +0200, Geert Uytterhoeven wrote:
> As platform_get_irq() now prints an error when the interrupt does not
> exist, a scary warning may be printed for an optional interrupt:
> sh_mmcif ee200000.mmc: IRQ index 1 not found
> Fix this by calling platform_get_irq_optional() instead for the second
> interrupt, which is optional.
> Remove the now superfluous error printing for the first interrupt, which
> is mandatory.
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <>

Reviewed-by: Wolfram Sang <>

Tested on a R-Car H2: it does make the error message go away and the
MMCIF device acts normal during boot. Can't enter userspace currently
with v5.4-rc1 but this is unrelated to this patch and MMCIF. Looks like a
configuration thing on my side, so I will still give:

Tested-by: Wolfram Sang <>

But will report back when I fixed the unrelated issue.

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-10-02 10:16    [W:0.063 / U:14.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site