Messages in this thread | | | Subject | Re: [PATCH v4 2/2] iio: (bma400) add driver for the BMA400 | From | Joe Perches <> | Date | Fri, 18 Oct 2019 21:25:00 -0700 |
| |
On Fri, 2019-10-18 at 03:18 +0000, Dan Robertson wrote: > Add a IIO driver for the Bosch BMA400 3-axes ultra-low power accelerometer. > The driver supports reading from the acceleration and temperature > registers. The driver also supports reading and configuring the output data > rate, oversampling ratio, and scale.
trivial logging note:
> diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c [] > +static int bma400_get_accel_reg(struct bma400_data *data, > + const struct iio_chan_spec *chan, > + int *val) > +{ [] > + dev_err(data->dev, "invalid axis channel modifier");
All the logging should use \n terminations
dev_err(data->dev, "invalid axis channel modifier\n"); [] > +static int bma400_get_accel_output_data_rate(struct bma400_data *data) > +{ [] > + dev_err(data->dev, "invalid ODR=%x", odr); should be: dev_err(data->dev, "invalid ODR=%x\n", odr);
etc...
| |