lkml.org 
[lkml]   [2019]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7] soc: fsl: qe: replace spin_event_timeout by readx_poll_timeout_atomic
On Fri, Oct 18, 2019 at 02:52:31PM +0200, Rasmus Villemoes wrote:
> /* wait for the QE_CR_FLG to clear */
> - ret = spin_event_timeout((ioread32be(&qe_immr->cp.cecr) & QE_CR_FLG) == 0,
> - 100, 0);
> - /* On timeout (e.g. failure), the expression will be false (ret == 0),
> - otherwise it will be true (ret == 1). */
> + ret = readx_poll_timeout_atomic(ioread32be, &qe_immr->cp.cecr, val, (val & QE_CR_FLG) == 0,

This creates an overly long line.

Btw, given how few users of spin_event_timeout we have it might be good
idea to just kill it entirely.

\
 
 \ /
  Last update: 2019-10-18 18:09    [W:0.500 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site