Messages in this thread | | | Date | Fri, 18 Oct 2019 08:56:43 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 8/8] riscv: for C functions called only from assembly, mark with __visible |
| |
On Fri, Oct 18, 2019 at 01:08:41AM -0700, Paul Walmsley wrote: > Rather than adding prototypes for C functions called only by assembly > code, mark them as __visible. This avoids adding prototypes that will > never be used by the callers. Resolves the following sparse warnings: > > arch/riscv/kernel/ptrace.c:151:6: warning: symbol 'do_syscall_trace_enter' was not declared. Should it be static? > arch/riscv/kernel/ptrace.c:175:6: warning: symbol 'do_syscall_trace_exit' was not declared. Should it be static? > > Based on a suggestion from Luc Van Oostenryck. > > Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |