Messages in this thread | | | Date | Fri, 18 Oct 2019 08:54:58 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 4/8] riscv: add missing prototypes |
| |
On Fri, Oct 18, 2019 at 01:08:37AM -0700, Paul Walmsley wrote: > > diff --git a/arch/riscv/include/asm/irq.h b/arch/riscv/include/asm/irq.h > index 75576424c0f7..589e2d9fb2a6 100644 > --- a/arch/riscv/include/asm/irq.h > +++ b/arch/riscv/include/asm/irq.h > @@ -12,6 +12,9 @@ > void riscv_timer_interrupt(void); > void riscv_software_interrupt(void); > > +asmlinkage void do_IRQ(struct pt_regs *regs);
This is another __visible candidate.
> +void __init init_IRQ(void);
This one is called by the core kernel. Please instead lift the extern in init/main.c to include/linux/irq.h or some other suitable header insted of working around the issue in arch code.
> index f539149d04c2..ab56435de629 100644 > --- a/arch/riscv/include/asm/processor.h > +++ b/arch/riscv/include/asm/processor.h > @@ -78,6 +78,10 @@ int riscv_of_processor_hartid(struct device_node *node); > > extern void riscv_fill_hwcap(void); > > +extern const struct seq_operations cpuinfo_op;
Another generic issue, Ben Dooks has started looking into it already.
> + > +void time_init(void);
And another one that needs to be solved globally and not worked around in the architecture.
> diff --git a/arch/riscv/include/asm/ptrace.h b/arch/riscv/include/asm/ptrace.h > index d48d1e13973c..c851c095b674 100644 > --- a/arch/riscv/include/asm/ptrace.h > +++ b/arch/riscv/include/asm/ptrace.h > @@ -101,6 +101,8 @@ static inline unsigned long regs_return_value(struct pt_regs *regs) > return regs->a0; > } > > +void show_regs(struct pt_regs *regs);
Again, this needs to go into a common header, no arch code.
> + > #endif /* __ASSEMBLY__ */ > > #endif /* _ASM_RISCV_PTRACE_H */ > diff --git a/arch/riscv/include/asm/smp.h b/arch/riscv/include/asm/smp.h > index a83451d73a4e..d19dd2e2e1da 100644 > --- a/arch/riscv/include/asm/smp.h > +++ b/arch/riscv/include/asm/smp.h > @@ -15,6 +15,8 @@ > struct seq_file; > extern unsigned long boot_cpu_hartid; > > +asmlinkage void __init smp_callin(void);
One more __visible candidate.
| |