lkml.org 
[lkml]   [2019]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm,thp: recheck each page before collapsing file THP
On Thu, Oct 17, 2019 at 10:08:32PM -0700, Song Liu wrote:
> + /* double check the page is correct and clean */
> + if (unlikely(!PageUptodate(page)) ||
> + unlikely(PageDirty(page)) ||
> + unlikely(page->mapping != mapping)) {

That's kind of an ugly way of writing it. Why not more simply:

if (unlikely(!PageUptodate(page) || PageDirty(page) ||
page->mapping != mapping)) {

\
 
 \ /
  Last update: 2019-10-18 16:27    [W:0.455 / U:23.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site