Messages in this thread | | | Date | Fri, 18 Oct 2019 07:25:23 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH] mm,thp: recheck each page before collapsing file THP |
| |
On Thu, Oct 17, 2019 at 10:08:32PM -0700, Song Liu wrote: > + /* double check the page is correct and clean */ > + if (unlikely(!PageUptodate(page)) || > + unlikely(PageDirty(page)) || > + unlikely(page->mapping != mapping)) {
That's kind of an ugly way of writing it. Why not more simply:
if (unlikely(!PageUptodate(page) || PageDirty(page) || page->mapping != mapping)) {
| |