Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 18 Oct 2019 10:52:19 +0300 | Subject | Re: [PATCH v2 20/33] platform/x86: intel_oaktrail: Use pr_warn instead of pr_warning |
| |
On Fri, Oct 18, 2019 at 6:19 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > > As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of > pr_warning"), removing pr_warning so all logging messages use a > consistent <prefix>_warn style. Let's do it.
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Corentin Chary <corentin.chary@gmail.com> > Cc: Darren Hart <dvhart@infradead.org> > Cc: Andy Shevchenko <andy@infradead.org> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/platform/x86/intel_oaktrail.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c > index 3c0438ba385e..1a09a75bd16d 100644 > --- a/drivers/platform/x86/intel_oaktrail.c > +++ b/drivers/platform/x86/intel_oaktrail.c > @@ -243,7 +243,7 @@ static int oaktrail_backlight_init(void) > > if (IS_ERR(bd)) { > oaktrail_bl_device = NULL; > - pr_warning("Unable to register backlight device\n"); > + pr_warn("Unable to register backlight device\n"); > return PTR_ERR(bd); > } > > @@ -313,20 +313,20 @@ static int __init oaktrail_init(void) > > ret = platform_driver_register(&oaktrail_driver); > if (ret) { > - pr_warning("Unable to register platform driver\n"); > + pr_warn("Unable to register platform driver\n"); > goto err_driver_reg; > } > > oaktrail_device = platform_device_alloc(DRIVER_NAME, -1); > if (!oaktrail_device) { > - pr_warning("Unable to allocate platform device\n"); > + pr_warn("Unable to allocate platform device\n"); > ret = -ENOMEM; > goto err_device_alloc; > } > > ret = platform_device_add(oaktrail_device); > if (ret) { > - pr_warning("Unable to add platform device\n"); > + pr_warn("Unable to add platform device\n"); > goto err_device_add; > } > > @@ -338,7 +338,7 @@ static int __init oaktrail_init(void) > > ret = oaktrail_rfkill_init(); > if (ret) { > - pr_warning("Setup rfkill failed\n"); > + pr_warn("Setup rfkill failed\n"); > goto err_rfkill; > } > > -- > 2.20.1 >
-- With Best Regards, Andy Shevchenko
| |