lkml.org 
[lkml]   [2019]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next] Bluetooth: btusb: Remove return statement in btintel_reset_to_bootloader
    Date
    When building with Clang and CONFIG_BT_INTEL unset, the following error
    occurs:

    In file included from drivers/bluetooth/hci_ldisc.c:34:
    drivers/bluetooth/btintel.h:188:2: error: void function
    'btintel_reset_to_bootloader' should not return a value [-Wreturn-type]
    return -EOPNOTSUPP;
    ^ ~~~~~~~~~~~
    1 error generated.

    Remove the unneeded return statement to fix this.

    Fixes: b9a2562f4918 ("Bluetooth: btusb: Trigger Intel FW download error recovery")
    Link: https://github.com/ClangBuiltLinux/linux/issues/743
    Reported-by: <ci_notify@linaro.org>
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    ---
    drivers/bluetooth/btintel.h | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
    index d2311156f778..a69ea8a87b9b 100644
    --- a/drivers/bluetooth/btintel.h
    +++ b/drivers/bluetooth/btintel.h
    @@ -185,6 +185,5 @@ static inline int btintel_download_firmware(struct hci_dev *dev,

    static inline void btintel_reset_to_bootloader(struct hci_dev *hdev)
    {
    - return -EOPNOTSUPP;
    }
    #endif
    --
    2.23.0
    \
     
     \ /
      Last update: 2019-10-19 00:31    [W:5.609 / U:3.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site