lkml.org 
[lkml]   [2019]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip: x86/asm] x86/asm/ftrace: Mark function_hook as function
    On Fri, 18 Oct 2019 21:48:56 +0200
    Borislav Petkov <bp@suse.de> wrote:

    > > The #define was because we use to support mcount or __fentry__, now we
    > > just support __fentry__, and function_hook describes it better ;-)
    >
    > Well sorry but gcc documentation talks about __fentry__. I'd keep the
    > same name to avoid confusion and explain above it what it is. Much
    > better.

    Still looks ugly ;-)

    >
    > > Heh, I guess we could, which would probably be quite a long comment as
    > > it's the key behind ftrace itself.
    >
    > Well, you can explain with a couple of sentences what it is and
    > then point at the bigger document explaining ftrace. Provided, Mr.
    > Rostedt, you'll stop doing talks and finally sit down and write that
    > documentation!

    I do the talks hoping someone else will finally sit down and write the
    documentation!

    -- Steve

    \
     
     \ /
      Last update: 2019-10-18 22:32    [W:4.210 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site