Messages in this thread | | | Date | Thu, 17 Oct 2019 17:02:23 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v5] printf: add support for printing symbolic error names |
| |
On Wed 2019-10-16 19:31:33, Andy Shevchenko wrote: > On Wed, Oct 16, 2019 at 5:52 PM Petr Mladek <pmladek@suse.com> wrote: > > > > On Wed 2019-10-16 16:49:41, Andy Shevchenko wrote: > > > On Tue, Oct 15, 2019 at 10:07 PM Rasmus Villemoes > > > <linux@rasmusvillemoes.dk> wrote: > > > > > > > +const char *errname(int err) > > > > +{ > > > > + const char *name = __errname(err > 0 ? err : -err); > > > > > > Looks like mine comment left unseen. > > > What about to simple use abs(err) here? > > > > Andy, would you want to ack the patch with this change? > > I could do it when pushing the patch. > > Looks good to me. > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
The patch has been committed into printk.git, branch for-5.5.
Best Regards, Petr
| |