Messages in this thread | | | Date | Thu, 17 Oct 2019 11:18:07 +0100 | From | Lorenzo Pieralisi <> | Subject | Re: [PATCH] PCI: mvebu: make mvebu_pci_bridge_emul_ops static |
| |
On Tue, Oct 15, 2019 at 05:09:30PM +0100, Ben Dooks (Codethink) wrote: > The mvebu_pci_bridge_emul_ops is not exported outside > of the driver, so make it static to avoid the following > sparse warning: > > drivers/pci/controller/pci-mvebu.c:557:28: warning: symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Andrew Murray <andrew.murray@arm.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/pci/controller/pci-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/misc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c > index d3a0419e42f2..ed032e9a3156 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, > } > } > > -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { > +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = { > .write_base = mvebu_pci_bridge_emul_base_conf_write, > .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read, > .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write, > -- > 2.23.0 >
| |