lkml.org 
[lkml]   [2019]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file
Hello Kamel,

On Thu, 17 Oct 2019 10:54:05 +0200
Kamel Bouhara <kamel.bouhara@bootlin.com> wrote:

> There are three different boards available depending on the PCB
> (3 antennas support and several revison). Add a dtsi file to share
> common binding between all kizbox2 boards.
>
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> Signed-off-by: Kévin RAYMOND <k.raymond@overkiz.com>
> Signed-off-by: Mickael GARDET <m.gardet@overkiz.com>
> ---
> arch/arm/boot/dts/Makefile | 6 +-
> arch/arm/boot/dts/at91-kizbox.dts | 173 +++++++-------

The changes to this file (change to use phandles) seem unrelated to the
current patch, unless I'm missing something.

> arch/arm/boot/dts/at91-kizbox2-0.dts | 17 ++
> arch/arm/boot/dts/at91-kizbox2-1.dts | 22 ++
> arch/arm/boot/dts/at91-kizbox2-2.dts | 26 +++
> arch/arm/boot/dts/at91-kizbox2-3.dts | 30 +++
> arch/arm/boot/dts/at91-kizbox2-rev2.dts | 34 +++
> arch/arm/boot/dts/at91-kizbox2.dts | 244 -------------------
> arch/arm/boot/dts/at91-kizbox2_common.dtsi | 258 +++++++++++++++++++++

"-" seems to be a much more common separator for DT names, including in
this file, so what about at91-kizbox2-common.dtsi ?

> +// WMBUS (inverted with IO in the latest schematic)

I am not sure C++ comments are common in Device Tree files.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2019-10-17 11:05    [W:0.058 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site