Messages in this thread | | | Subject | Re: [PATCH v2] perf list: Separate the deprecated events | From | "Jin, Yao" <> | Date | Fri, 18 Oct 2019 08:13:57 +0800 |
| |
On 10/17/2019 11:21 PM, Jiri Olsa wrote: > On Thu, Oct 17, 2019 at 07:46:44AM -0700, Andi Kleen wrote: >>> v2: >>> --- >>> In v1, the deprecated events are hidden by default but they can be >>> displayed when option "--deprecated" is enabled. In v2, we don't use >>> the new option "--deprecated". Instead, we just display the deprecated >>> events under the title "--- Following are deprecated events ---". >> >> It's redundant with what the event description already says. >> If we always want to show it we don't need to do anything. >> >> I really would much prefer to hide it. What's the point of showing >> something that people are not supposed to use? >> >> The only reason for keeping the deprecated events is to not >> break old scripts, but those don't care about perf list output. > > I thought this might be a problem for users, > but don't have anything to back this up ;-) > > if that's the case we can go with the original patch > > jirka >
I'm fine to go with the original patch. :)
Thanks Jin Yao
>> >> So I think the only sane option is to hide it by default. >> >> -Andi
| |