Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH 1/4] parport: daisy: avoid hardcoded name | Date | Wed, 16 Oct 2019 15:45:37 +0100 |
| |
The daisy device name is hardcoded, define it in the header file and use it in the code.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> --- drivers/parport/probe.c | 2 +- include/linux/parport.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c index e035174ba205..4e2bfeb6b4a6 100644 --- a/drivers/parport/probe.c +++ b/drivers/parport/probe.c @@ -257,7 +257,7 @@ static ssize_t parport_read_device_id (struct parport *port, char *buffer, ssize_t parport_device_id (int devnum, char *buffer, size_t count) { ssize_t retval = -ENXIO; - struct pardevice *dev = parport_open (devnum, "Device ID probe"); + struct pardevice *dev = parport_open(devnum, daisy_dev_name); if (!dev) return -ENXIO; diff --git a/include/linux/parport.h b/include/linux/parport.h index 397607a0c0eb..13932ce8b37b 100644 --- a/include/linux/parport.h +++ b/include/linux/parport.h @@ -460,6 +460,7 @@ extern size_t parport_ieee1284_epp_read_addr (struct parport *, void *, size_t, int); /* IEEE1284.3 functions */ +#define daisy_dev_name "Device ID probe" extern int parport_daisy_init (struct parport *port); extern void parport_daisy_fini (struct parport *port); extern struct pardevice *parport_open (int devnum, const char *name); -- 2.11.0
| |