Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 16 Oct 2019 14:27:44 +0200 | Subject | Re: [PATCH v2 1/4] dt-bindings: gpio: Add devicetree binding for RDA Micro GPIO controller |
| |
On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> Add YAML devicetree binding for RDA Micro GPIO controller. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
First: this looks awesome to me,
Second: since this is kind of a first... could we move the standard GPIOchip YAML business into a generic gpiochip .yaml file?
We currently only have pl061-gpio.yaml and this would duplicate a lot of the stuff from that yaml file.
If you look at how display/panel/panel-common.yaml is used from say display/panel/ti,nspire.yaml
Could we do something similar and lift out all the generics from gpio-pl061.yaml to gpio-common.yaml and reference that also in the new binding?
If it seems hard, tell me and I can take a stab at it.
Yours, Linus Walleij
| |