Messages in this thread | | | From | Oded Gabbay <> | Date | Wed, 16 Oct 2019 12:13:07 +0300 | Subject | Re: [PATCH -next] habanalabs: remove set but not used variable 'qman_base_addr' |
| |
On Wed, Oct 16, 2019 at 11:48 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/habanalabs/goya/goya.c: In function 'goya_init_mme_cmdq': > drivers/misc/habanalabs/goya/goya.c:1536:6: warning: > variable 'qman_base_addr' set but not used [-Wunused-but-set-variable] > > It is never used, so can be removed. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/misc/habanalabs/goya/goya.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c > index 6fba14b..1ef34ec 100644 > --- a/drivers/misc/habanalabs/goya/goya.c > +++ b/drivers/misc/habanalabs/goya/goya.c > @@ -1533,7 +1533,6 @@ static void goya_init_mme_cmdq(struct hl_device *hdev) > u32 mtr_base_lo, mtr_base_hi; > u32 so_base_lo, so_base_hi; > u32 gic_base_lo, gic_base_hi; > - u64 qman_base_addr; > > mtr_base_lo = lower_32_bits(CFG_BASE + mmSYNC_MNGR_MON_PAY_ADDRL_0); > mtr_base_hi = upper_32_bits(CFG_BASE + mmSYNC_MNGR_MON_PAY_ADDRL_0); > @@ -1545,9 +1544,6 @@ static void goya_init_mme_cmdq(struct hl_device *hdev) > gic_base_hi = > upper_32_bits(CFG_BASE + mmGIC_DISTRIBUTOR__5_GICD_SETSPI_NSR); > > - qman_base_addr = hdev->asic_prop.sram_base_address + > - MME_QMAN_BASE_OFFSET; > - > WREG32(mmMME_CMDQ_CP_MSG_BASE0_ADDR_LO, mtr_base_lo); > WREG32(mmMME_CMDQ_CP_MSG_BASE0_ADDR_HI, mtr_base_hi); > WREG32(mmMME_CMDQ_CP_MSG_BASE1_ADDR_LO, so_base_lo); > -- > 2.7.4 > >
This patch is: Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com> Applied to -next Thanks, Oded
| |