lkml.org 
[lkml]   [2019]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 25/92] kernel/elfcore.c: include proper prototypes
    Date
    From: Valdis Kletnieks <valdis.kletnieks@vt.edu>

    [ Upstream commit 0f74914071ab7e7b78731ed62bf350e3a344e0a5 ]

    When building with W=1, gcc properly complains that there's no prototypes:

    CC kernel/elfcore.o
    kernel/elfcore.c:7:17: warning: no previous prototype for 'elf_core_extra_phdrs' [-Wmissing-prototypes]
    7 | Elf_Half __weak elf_core_extra_phdrs(void)
    | ^~~~~~~~~~~~~~~~~~~~
    kernel/elfcore.c:12:12: warning: no previous prototype for 'elf_core_write_extra_phdrs' [-Wmissing-prototypes]
    12 | int __weak elf_core_write_extra_phdrs(struct coredump_params *cprm, loff_t offset)
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~
    kernel/elfcore.c:17:12: warning: no previous prototype for 'elf_core_write_extra_data' [-Wmissing-prototypes]
    17 | int __weak elf_core_write_extra_data(struct coredump_params *cprm)
    | ^~~~~~~~~~~~~~~~~~~~~~~~~
    kernel/elfcore.c:22:15: warning: no previous prototype for 'elf_core_extra_data_size' [-Wmissing-prototypes]
    22 | size_t __weak elf_core_extra_data_size(void)
    | ^~~~~~~~~~~~~~~~~~~~~~~~

    Provide the include file so gcc is happy, and we don't have potential code drift

    Link: http://lkml.kernel.org/r/29875.1565224705@turing-police
    Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/elfcore.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/kernel/elfcore.c b/kernel/elfcore.c
    index e556751d15d94..a2b29b9bdfcb2 100644
    --- a/kernel/elfcore.c
    +++ b/kernel/elfcore.c
    @@ -2,6 +2,7 @@
    #include <linux/fs.h>
    #include <linux/mm.h>
    #include <linux/binfmts.h>
    +#include <linux/elfcore.h>

    Elf_Half __weak elf_core_extra_phdrs(void)
    {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-17 00:19    [W:4.384 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site