lkml.org 
[lkml]   [2019]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 68/92] USB: legousbtower: fix slab info leak at probe
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 1d427be4a39defadda6dd8f4659bc17f7591740f upstream.

    Make sure to check for short transfers when retrieving the version
    information at probe to avoid leaking uninitialised slab data when
    logging it.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20190919083039.30898-2-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/misc/legousbtower.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/usb/misc/legousbtower.c
    +++ b/drivers/usb/misc/legousbtower.c
    @@ -911,8 +911,10 @@ static int tower_probe (struct usb_inter
    get_version_reply,
    sizeof(*get_version_reply),
    1000);
    - if (result < 0) {
    - dev_err(idev, "LEGO USB Tower get version control request failed\n");
    + if (result < sizeof(*get_version_reply)) {
    + if (result >= 0)
    + result = -EIO;
    + dev_err(idev, "get version request failed: %d\n", result);
    retval = result;
    goto error;
    }

    \
     
     \ /
      Last update: 2019-10-16 23:55    [W:4.393 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site