Messages in this thread | | | Subject | Re: [PATCH v3 2/3] selftests/livepatch: Make dynamic debug setup and restore generic | From | Joe Lawrence <> | Date | Wed, 16 Oct 2019 17:39:17 -0400 |
| |
On 10/16/19 1:10 PM, Kamalesh Babulal wrote: > On 10/16/19 5:03 PM, Miroslav Benes wrote: >> From: Joe Lawrence <joe.lawrence@redhat.com> >> >> Livepatch selftests currently save the current dynamic debug config and >> tweak it for the selftests. The config is restored at the end. Make the >> infrastructure generic, so that more variables can be saved and >> restored. >> >> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> >> Signed-off-by: Miroslav Benes <mbenes@suse.cz> >> --- >> .../testing/selftests/livepatch/functions.sh | 22 +++++++++++-------- >> .../selftests/livepatch/test-callbacks.sh | 2 +- >> .../selftests/livepatch/test-livepatch.sh | 2 +- >> .../selftests/livepatch/test-shadow-vars.sh | 2 +- > > A minor nit pick, should the README also updated with the setup_config()? >
Yup, good eye. I think it should be a simple matter of s/set_dynamic_debug/setup_config/g
-- Joe
| |