Messages in this thread | | | From | Hsin-Yi Wang <> | Date | Tue, 15 Oct 2019 17:44:53 +0800 | Subject | Re: [PATCH] random: inform about bootloader-provided randomness |
| |
On Tue, Oct 15, 2019 at 8:40 AM Will Deacon <will@kernel.org> wrote: > > On Sat, Oct 05, 2019 at 01:36:32PM +0200, Dominik Brodowski wrote: > > Inform how many bits of randomness were provided by the bootloader, > > and whether we trust that input. > > > > Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Hsin-Yi Wang <hsinyi@chromium.org> > > Cc: Stephen Boyd <swboyd@chromium.org> > > Cc: Rob Herring <robh@kernel.org> > > Cc: Theodore Ts'o <tytso@mit.edu> > > Cc: Will Deacon <will@kernel.org> > > > > diff --git a/drivers/char/random.c b/drivers/char/random.c > > index de434feb873a..673375e05c0d 100644 > > --- a/drivers/char/random.c > > +++ b/drivers/char/random.c > > @@ -2515,6 +2515,10 @@ EXPORT_SYMBOL_GPL(add_hwgenerator_randomness); > > */ > > void add_bootloader_randomness(const void *buf, unsigned int size) > > { > > + pr_notice("random: adding %u bits of %sbootloader-provided randomness", > > + size * 8, > > + IS_ENABLED(CONFIG_RANDOM_TRUST_BOOTLOADER) ? "trusted " : ""); > > + > > if (IS_ENABLED(CONFIG_RANDOM_TRUST_BOOTLOADER)) > > add_hwgenerator_randomness(buf, size, size * 8); > > else > > Looks fine to me: > > Acked-by: Will Deacon <will@kernel.org> > > Will
Thanks.
Acked-by: Hsin-Yi Wang <hsinyi@chromium.org>
| |