Messages in this thread | | | Date | Wed, 16 Oct 2019 09:10:54 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 13/14] cpufreq: Use vtime aware kcpustat accessor to fetch CPUTIME_SYSTEM |
| |
On 16-10-19, 04:56, Frederic Weisbecker wrote: > Now that we have a vtime safe kcpustat accessor for CPUTIME_SYSTEM, use > it to start fixing frozen kcpustat values on nohz_full CPUs. > > Reported-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Yauheni Kaliuta <yauheni.kaliuta@redhat.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Rik van Riel <riel@surriel.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Wanpeng Li <wanpengli@tencent.com> > Cc: Ingo Molnar <mingo@kernel.org> > --- > drivers/cpufreq/cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index c52d6fa32aac..a37ebfd7e0e8 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -120,7 +120,7 @@ static inline u64 get_cpu_idle_time_jiffy(unsigned int cpu, u64 *wall) > cur_wall_time = jiffies64_to_nsecs(get_jiffies_64()); > > busy_time = kcpustat_cpu(cpu).cpustat[CPUTIME_USER]; > - busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_SYSTEM]; > + busy_time += kcpustat_field(&kcpustat_cpu(cpu), CPUTIME_SYSTEM, cpu); > busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_IRQ]; > busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_SOFTIRQ]; > busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_STEAL];
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |