Messages in this thread | | | From | Ian Rogers <> | Date | Mon, 14 Oct 2019 17:34:52 -0700 | Subject | Re: [PATCH 15/15] perf annotate: ensure objdump argv is NULL terminated |
| |
Apologies, resending with the correct patch number.
On Mon, Oct 14, 2019 at 5:33 PM Ian Rogers <irogers@google.com> wrote: > > Provide null termination. > > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/util/annotate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index f7c620e0099b..a9089e64046d 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -1921,6 +1921,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args) > NULL, /* Will be the objdump command to run. */ > "--", > NULL, /* Will be the symfs path. */ > + NULL, > }; > struct child_process objdump_process; > int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename)); > -- > 2.23.0.700.g56cf767bdb-goog >
| |