lkml.org 
[lkml]   [2019]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/10] leds: pca953x: Use of_device_get_match_data()
Date
Quoting Andy Shevchenko (2019-10-14 10:50:06)
> On Sat, Oct 5, 2019 at 12:47 AM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > This driver can use the of_device_get_match_data() API to simplify the
> > code. Replace calls to of_match_device() with this newer API under the
> > assumption that where it is called will be when we know the device is
> > backed by a DT node. This nicely avoids referencing the match table when
> > it is undefined with configurations where CONFIG_OF=n.
>
> > + devid = (int)(uintptr_t)of_device_get_match_data(dev);
>
> > + devid = (int)(uintptr_t)of_device_get_match_data(&client->dev);
>
> This still leaves it OF-centric.
> Better to use device_get_match_data().
>
> Also, I'm thinking that following may help to clean a lot of the i2c
> client drivers
>
> static inline // perhaps no
> const void *i2c_device_get_match_data(struct i2c_client *client, const
> struct i2c_device_id *id)
> {
> if (id)
> return (const void *)id->driver_data;
> return device_get_match_data(&client->dev);
> }
>

Looks alright to me. Maybe device_get_match_data() can look at the bus
and call some bus op if the firmware match isn't present? Then we can
replace a bunch of these calls with device_get_match_data() and it will
"do the right thing" regardless of what bus or firmware the device is
running on.

\
 
 \ /
  Last update: 2019-10-14 22:54    [W:0.094 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site