lkml.org 
[lkml]   [2019]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: tcp: Checking a kmemdup() call in tcp_time_wait()
From
Date
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306
>>>> https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306


>> Can an other error reporting approach be nicer here?
>
> There is no error reported if kmemdup() has failed.

How do data from the Linux allocation failure report fit to this information?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=4f5cafb5cb8471e54afdc9054d973535614f7675#n878


> timewait is best effort.

How do you think about to return an error code like “-ENOMEM” at this place?

Regards,
Markus

\
 
 \ /
  Last update: 2019-10-14 14:52    [W:0.506 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site