Messages in this thread Patch in this message | | | Date | Mon, 14 Oct 2019 15:36:04 +0300 | From | Zahari Petkov <> | Subject | [PATCH] leds: pca963x: Fix open-drain initialization |
| |
OUTDRV setting (bit 2) of Mode register 2 has a default value of 1. During initialization when open-drain is used, instead of setting OUTDRV to 0, the driver keeps it as 1. OUTDRV setting is now correctly initialized to 0 when open-drain is used.
Additionally the BIT macro is used for improved readibility.
Fixes: bb29b9cccd95 ("leds: pca963x: Add bindings to invert polarity") Signed-off-by: Zahari Petkov <zahari@balena.io> --- drivers/leds/leds-pca963x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c index 4afc317901a8..e3da2156b385 100644 --- a/drivers/leds/leds-pca963x.c +++ b/drivers/leds/leds-pca963x.c @@ -438,12 +438,12 @@ static int pca963x_probe(struct i2c_client *client, PCA963X_MODE2); /* Configure output: open-drain or totem pole (push-pull) */ if (pdata->outdrv == PCA963X_OPEN_DRAIN) - mode2 |= 0x01; + mode2 &= ~BIT(2); else - mode2 |= 0x05; + mode2 |= BIT(2); /* Configure direction: normal or inverted */ if (pdata->dir == PCA963X_INVERTED) - mode2 |= 0x10; + mode2 |= BIT(4); i2c_smbus_write_byte_data(pca963x->chip->client, PCA963X_MODE2, mode2); } -- 2.23.0
| |