lkml.org 
[lkml]   [2019]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 5/6] x86/ftrace: Use text_poke()
    On Fri, 11 Oct 2019 14:59:03 +0200
    Peter Zijlstra <peterz@infradead.org> wrote:

    > On Thu, Oct 10, 2019 at 07:28:19PM +0200, Peter Zijlstra wrote:
    >
    > > Really the best solution is to move all the poking into
    > > ftrace_module_init(), before we mark it RO+X. That's what I'm going to
    > > do for jump_label and static_call as well, I just need to add that extra
    > > notifier callback.
    >
    > OK, so I started writing that patch... or rather, I wrote the patch and
    > started on the Changelog when I ran into trouble describing why we need
    > it.
    >
    > That is, I'm struggling to explain why we cannot flip
    > prepare_coming_module() and complete_formation().
    >
    > Yes, it breaks ftrace, but I'm thinking that is all it breaks. So let me
    > see if we can cure that.

    For someone that doesn't use modules, you are making me very nervous
    with all the changes you are making to the module code! ;-)

    -- Steve

    \
     
     \ /
      Last update: 2019-10-11 15:35    [W:5.620 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site