lkml.org 
[lkml]   [2019]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 04/12] nvmet: make nvmet_copy_ns_identifier() non-static
On Wed, Oct 09, 2019 at 01:25:21PM -0600, Logan Gunthorpe wrote:
> This function will be needed by the upcoming passthru code.
>
> Passthru will need an emulated version of identify_desclist which
> copies the eui64, uuid and nguid from the passed-thru controller into
> the request SGL.

I don't like the way this is handled. We should avoid faking up
behavior not supported if this really is a passthrough interface.

For this particular case this means:

1) report the vs field that the actual controller reports
2) if that is below 1.2.1 bump it to that, but no further
(and maybe print a warning)
3) don't emulate the namespace descriptor CNS ever

\
 
 \ /
  Last update: 2019-10-10 13:51    [W:0.156 / U:5.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site