Messages in this thread | | | Date | Tue, 1 Oct 2019 09:28:42 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v4 1/4] lib: introduce copy_struct_from_user() helper |
| |
On Tue, Oct 01, 2019 at 04:31:27AM +0200, Christian Brauner wrote: > On Mon, Sep 30, 2019 at 06:58:39PM -0700, Kees Cook wrote: > > On Tue, Oct 01, 2019 at 11:10:52AM +1000, Aleksa Sarai wrote: > > > +static __always_inline > > > +int copy_struct_from_user(void *dst, size_t ksize, > > > + const void __user *src, size_t usize) > > > > And of course I forgot to realize both this and check_zeroed_user() > > should also have the __must_check attribute. Sorry for forgetting that > > earlier! > > Just said to Aleksa that I'll just fix this up when I apply so he > doesn't have to resend. You ok with this, Kees?
Yup; that's totally fine. Thanks!
-- Kees Cook
| |