lkml.org 
[lkml]   [2019]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] fs: affs: fix a memory leak in affs_remount
From
Date
> The allocated memory for new_opts is only released if pare_options fail.

Can the following wording be nicer?

The allocated memory for the buffer “new_opts” will be released
only if a call of the function “parse_options” failed.


> The release for new_opts is added.

* How do you think about the change possibility to delete questionable
source code here?

* Would you like to complete the data processing for corresponding options
any more?


> -- fix a type in title, …

Please avoid typos also in your version comments.


> ---

I suggest to replace this second delimiter by a blank line.

Regards,
Markus

\
 
 \ /
  Last update: 2019-10-01 10:32    [W:0.983 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site