Messages in this thread | | | From | Navid Emamdoost <> | Date | Tue, 1 Oct 2019 12:32:41 -0500 | Subject | Re: [PATCH v2] spi: gpio: prevent memory leak in spi_gpio_probe |
| |
Hi Markus, thanks for your suggestions for improving the quality of the patch. At the moment I prefer first get a confirmation from contributors about the leak and then work on any possible improvements for the patch.
Thanks, Navid.
On Tue, Oct 1, 2019 at 4:11 AM Markus Elfring <Markus.Elfring@web.de> wrote: > > > … In order to avoid leak spi_contriller_put must > > be called in case of failure for devm_add_action_or_reset. > > How does this wording fit to the diff display that you would like > to add the function call “spi_master_put(master)” in > one if branch? > > > > Fixes: 8b797490b4db ("spi: gpio: Make sure spi_master_put() is called in every error path") > > Is there a need to complete the corresponding exception handling > at any more source code places? > > Regards, > Markus
-- Navid.
| |